1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215 | // Copyright (C) 2016-2024 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
#include <config.h>
#include <gtest/gtest.h><--- Include file: not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <dhcpsrv/parsers/simple_parser4.h>
#include <dhcp4/tests/dhcp4_test_utils.h>
#include <cc/data.h>
using namespace isc::data;
namespace isc {
namespace dhcp {
namespace test {
/// @brief DHCP Parser test fixture class
class SimpleParser4Test : public ::testing::Test {
public:
/// @brief Checks if specified map has an integer parameter with expected value
///
/// @param map map to be checked
/// @param param_name name of the parameter to be checked
/// @param exp_value expected value of the parameter.
void checkIntegerValue(const ConstElementPtr& map, const std::string& param_name,
int64_t exp_value) {
// First check if the passed element is a map.
ASSERT_EQ(Element::map, map->getType());
// Now try to get the element being checked
ConstElementPtr elem = map->get(param_name);
ASSERT_TRUE(elem);
// Now check if it's indeed integer
ASSERT_EQ(Element::integer, elem->getType());
// Finally, check if its value meets expectation.
EXPECT_EQ(exp_value, elem->intValue());
}
/// @brief Checks if specified map has a string parameter with expected value
///
/// @param map map to be checked
/// @param param_name name of the parameter to be checked
/// @param exp_value expected value of the parameter.
void checkStringValue(const ConstElementPtr& map, const std::string& param_name,
std::string exp_value) {
// First check if the passed element is a map.
ASSERT_EQ(Element::map, map->getType());
// Now try to get the element being checked
ConstElementPtr elem = map->get(param_name);
ASSERT_TRUE(elem);
// Now check if it's indeed integer
ASSERT_EQ(Element::string, elem->getType());
// Finally, check if its value meets expectation.
EXPECT_EQ(exp_value, elem->stringValue());
}
/// @brief Checks if specified map has a boolean parameter with expected value
///
/// @param map map to be checked
/// @param param_name name of the parameter to be checked
/// @param exp_value expected value of the parameter.
void checkBoolValue(const ConstElementPtr& map, const std::string& param_name,
bool exp_value) {
// First check if the passed element is a map.
ASSERT_EQ(Element::map, map->getType());
// Now try to get the element being checked
ConstElementPtr elem = map->get(param_name);
ASSERT_TRUE(elem);
// Now check if it's indeed integer
ASSERT_EQ(Element::boolean, elem->getType());
// Finally, check if its value meets expectation.
EXPECT_EQ(exp_value, elem->boolValue());
}
};
// This test checks if global defaults are properly set for DHCPv4.
TEST_F(SimpleParser4Test, globalDefaults4) {<--- syntax error
ElementPtr empty = parseJSON("{ }");
size_t num = 0;
EXPECT_NO_THROW(num = SimpleParser4::setAllDefaults(empty));
// We expect at least 1 parameter to be inserted.
EXPECT_TRUE(num >= 1);
checkIntegerValue(empty, "valid-lifetime", 7200);
// Timers are optional and by default are not present
EXPECT_FALSE(empty->contains("rebind-timer"));
EXPECT_FALSE(empty->contains("renew-timer"));
// Make sure that preferred-lifetime is not set for v4 (it's v6 only
// parameter)
EXPECT_FALSE(empty->get("preferred-lifetime"));
}
// This test checks if the parameters can be inherited from the global
// scope to the subnet scope.
TEST_F(SimpleParser4Test, inheritGlobalToSubnet4) {
ElementPtr global = parseJSON("{ \"renew-timer\": 1,"
" \"rebind-timer\": 2,"
" \"valid-lifetime\": 4,"
" \"min-valid-lifetime\": 3,"
" \"max-valid-lifetime\": 5,"
" \"subnet4\": [ { \"renew-timer\": 100 } ] "
"}");
ConstElementPtr subnets = global->find("subnet4");
ASSERT_TRUE(subnets);
ConstElementPtr subnet = subnets->get(0);
ASSERT_TRUE(subnet);
// we should inherit 4 parameters. Renew-timer should remain intact,
// as it was already defined in the subnet scope.
size_t num;
EXPECT_NO_THROW(num = SimpleParser4::deriveParameters(global));
EXPECT_EQ(4, num);
// Check the values. 2 of them are inherited, while the third one
// was already defined in the subnet, so should not be inherited.
checkIntegerValue(subnet, "renew-timer", 100);
checkIntegerValue(subnet, "rebind-timer", 2);
checkIntegerValue(subnet, "valid-lifetime", 4);
checkIntegerValue(subnet, "min-valid-lifetime", 3);
checkIntegerValue(subnet, "max-valid-lifetime", 5);
}
// This test checks if the parameters in "subnet4" are assigned default values
// if not explicitly specified.
TEST_F(SimpleParser4Test, subnetDefaults4) {
ElementPtr global = parseJSON("{ \"renew-timer\": 1,"
" \"rebind-timer\": 2,"
" \"valid-lifetime\": 4,"
" \"subnet4\": [ { } ] "
"}");
size_t num = 0;
EXPECT_NO_THROW(num = SimpleParser4::setAllDefaults(global));
EXPECT_LE(1, num); // at least 1 parameter has to be modified
ConstElementPtr subnets = global->find("subnet4");
ASSERT_TRUE(subnets);
ConstElementPtr subnet = subnets->get(0);
ASSERT_TRUE(subnet);
// no "id" where added.
ASSERT_FALSE(subnet->get("id"));
}
// This test checks if the parameters in option-data are assigned default values
// if not explicitly specified.
TEST_F(SimpleParser4Test, optionDataDefaults4) {
ElementPtr global = parseJSON("{ \"renew-timer\": 1,"
" \"rebind-timer\": 2,"
" \"valid-lifetime\": 4,"
" \"option-data\": [ { } ] "
"}");
size_t num = 0;
EXPECT_NO_THROW(num = SimpleParser4::setAllDefaults(global));
EXPECT_LE(1, num); // at least 1 parameter has to be modified
ConstElementPtr options = global->find("option-data");
ASSERT_TRUE(options);
ConstElementPtr option = options->get(0);
ASSERT_TRUE(option);
// we should have appropriate default value set. See
// SimpleParser4::OPTION4_DEFAULTS for a list of default values.
checkStringValue(option, "space", "dhcp4");
checkBoolValue(option, "csv-format", true);
}
// This test checks if the parameters in option-data are assigned default values
// if not explicitly specified.
TEST_F(SimpleParser4Test, optionDefDefaults4) {
ElementPtr global = parseJSON("{ "
" \"option-def\": [ { } ] "
"}");
size_t num = 0;
EXPECT_NO_THROW(num = SimpleParser4::setAllDefaults(global));
EXPECT_LE(1, num); // at least 1 parameter has to be modified
ConstElementPtr defs = global->find("option-def");
ASSERT_TRUE(defs);
ASSERT_EQ(1, defs->size());
ConstElementPtr def = defs->get(0);
ASSERT_TRUE(def);
// we should have appropriate default value set. See
// SimpleParser4::OPTION4_DEFAULTS for a list of default values.
checkStringValue(def, "record-types", "");
checkStringValue(def, "space", "dhcp4");
checkStringValue(def, "encapsulate", "");
checkBoolValue(def, "array", false);
}
};
};
};
|