1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287 | // Copyright (C) 2023 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the Kea Hooks Basic
// Commercial End User License Agreement v2.0. See COPYING file in the premium/
// directory.
/// @file This file contains tests which exercise the PingCheckConfig class.
#include <config.h>
#include <ping_check_config.h><--- Include file: not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <testutils/gtest_utils.h>
#include <gtest/gtest.h><--- Include file: not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <list><--- Include file: not found. Please note: Cppcheck does not need standard library headers to get proper results.
using namespace std;
using namespace isc;
using namespace isc::data;
using namespace isc::ping_check;
namespace {
// Verifies PingCheckConfig constructors and accessors.
TEST(PingCheckConfigTest, basics) {
PingCheckConfig config;
// Verify initial values.
EXPECT_TRUE(config.getEnablePingCheck());
EXPECT_EQ(1, config.getMinPingRequests());
EXPECT_EQ(100, config.getReplyTimeout());
EXPECT_EQ(60, config.getPingClttSecs());
EXPECT_EQ(0, config.getPingChannelThreads());
// Verify accessors.
EXPECT_NO_THROW_LOG(config.setEnablePingCheck(false));
EXPECT_FALSE(config.getEnablePingCheck());
EXPECT_NO_THROW_LOG(config.setMinPingRequests(4));
EXPECT_EQ(4, config.getMinPingRequests());
EXPECT_NO_THROW_LOG(config.setReplyTimeout(250));
EXPECT_EQ(250, config.getReplyTimeout());
EXPECT_NO_THROW_LOG(config.setPingClttSecs(120));
EXPECT_EQ(120, config.getPingClttSecs());
EXPECT_NO_THROW_LOG(config.setPingChannelThreads(6));
EXPECT_EQ(6, config.getPingChannelThreads());
// Verify copy construction.
PingCheckConfig config2(config);
EXPECT_FALSE(config2.getEnablePingCheck());
EXPECT_EQ(4, config2.getMinPingRequests());
EXPECT_EQ(250, config2.getReplyTimeout());
EXPECT_EQ(120, config2.getPingClttSecs());
EXPECT_EQ(6, config2.getPingChannelThreads());
}
// Exercises PingCheckConfig parameter parsing with valid configuration
// permutations.
TEST(PingCheckConfigTest, parseValidScenarios) {<--- syntax error
// Describes a test scenario.
struct Scenario {
int line_; // Scenario line number
std::string json_; // JSON configuration to parse
bool exp_enable_ping_check_; // Expected value for enable-ping-check
uint32_t exp_min_ping_requests_; // Expected value for min-ping-requests
uint32_t exp_reply_timeout_; // Expected value for reply-timeout
uint32_t exp_ping_cltt_secs_; // Expected value for ping-cltt-secs
size_t exp_num_threads_; // Expected value for ping-channel-threads
};
// List of test scenarios to run.
list<Scenario> scenarios = {
{
// Empty map
__LINE__,
R"({ })",
true, 1, 100, 60, 0
},
{
// Only enable-ping-check",
__LINE__,
R"({ "enable-ping-check" : false })",
false, 1, 100, 60, 0
},
{
// Only min-ping-requests",
__LINE__,
R"({ "min-ping-requests" : 3 })",
true, 3, 100, 60, 0
},
{
// Only reply-timeout",
__LINE__,
R"({ "reply-timeout" : 250 })",
true, 1, 250, 60, 0
},
{
// Only ping-cltt-secs",
__LINE__,
R"({ "ping-cltt-secs" : 77 })",
true, 1, 100, 77, 0
},
{
// Only ping-channel-threads",
__LINE__,
R"({ "ping-channel-threads" : 5 })",
true, 1, 100, 60, 5
},
{
// All parameters",
__LINE__,
R"(
{
"enable-ping-check" : false,
"min-ping-requests" : 2,
"reply-timeout" : 375,
"ping-cltt-secs" : 120,
"ping-channel-threads" : 6
})",
false, 2, 375, 120, 6
},
};
// Iterate over the scenarios.
for (auto const& scenario : scenarios) {
stringstream oss;
oss << "scenario at line: " << scenario.line_;
SCOPED_TRACE(oss.str());
// Convert JSON texts to Element map.
ConstElementPtr json_elements;
ASSERT_NO_THROW_LOG(json_elements = Element::fromJSON(scenario.json_));
// Parsing elements should succeed.
PingCheckConfig config;
ASSERT_NO_THROW_LOG(config.parse(json_elements));
// Verify expected values.
EXPECT_EQ(scenario.exp_enable_ping_check_, config.getEnablePingCheck());
EXPECT_EQ(scenario.exp_min_ping_requests_, config.getMinPingRequests());
EXPECT_EQ(scenario.exp_reply_timeout_, config.getReplyTimeout());
EXPECT_EQ(scenario.exp_ping_cltt_secs_, config.getPingClttSecs());
EXPECT_EQ(scenario.exp_num_threads_, config.getPingChannelThreads());
}
}
// Exercises PingCheckConfig parameter parsing with invalid configuration
// permutations.
TEST(PingCheckConfigTest, parseInvalidScenarios) {
// Describes a test scenario.
struct Scenario {
int line_; // Scenario line number
string json_; // JSON configuration to parse
string exp_message_; // Expected exception message
};
// List of test scenarios to run. Most scenario supply
// all valid parameters except one in error. This allows
// us to verify that no values are changed if any are in error.
list<Scenario> scenarios = {
{
__LINE__,
R"(
{
"enable-ping-check" : false,
"min-ping-requests" : 3,
"reply-timeout" : 250,
"ping-cltt-secs" : 90,
"ping-channel-threads" : 4,
"bogus" : false
})",
"spurious 'bogus' parameter"
},
{
__LINE__,
R"(
{
"enable-ping-check" : "not bool",
"min-ping-requests" : 3,
"reply-timeout" : 250,
"ping-cltt-secs" : 90,
"ping-channel-threads" : 4
})",
"'enable-ping-check' parameter is not a boolean"
},
{
__LINE__,
R"(
{
"enable-ping-check" : false,
"min-ping-requests" : 0,
"reply-timeout" : 250,
"ping-cltt-secs" : 90,
"ping-channel-threads" : 4
})",
"invalid min-ping-requests: '0', must be greater than 0"
},
{
__LINE__,
R"(
{
"enable-ping-check" : false,
"min-ping-requests" : -2,
"reply-timeout" : 250,
"ping-cltt-secs" : 90,
"ping-channel-threads" : 4
})",
"invalid min-ping-requests: '-2', must be greater than 0"
},
{
__LINE__,
R"(
{
"enable-ping-check" : false,
"min-ping-requests" : 1,
"reply-timeout" : 0,
"ping-cltt-secs" : 90,
"ping-channel-threads" : 4
})",
"invalid reply-timeout: '0', must be greater than 0"
},
{
__LINE__,
R"(
{
"enable-ping-check" : false,
"min-ping-requests" : 1,
"reply-timeout" : -77,
"ping-cltt-secs" : 90,
"ping-channel-threads" : 4
})",
"invalid reply-timeout: '-77', must be greater than 0"
},
{
__LINE__,
R"(
{
"enable-ping-check" : false,
"min-ping-requests" : 1,
"reply-timeout" : 250,
"ping-cltt-secs" : -3,
"ping-channel-threads" : 4
})",
"invalid ping-cltt-secs: '-3', cannot be less than 0"
},
{
__LINE__,
R"(
{
"enable-ping-check" : false,
"min-ping-requests" : 1,
"reply-timeout" : 250,
"ping-cltt-secs" : 90,
"ping-channel-threads" : -1
})",
"invalid ping-channel-threads: '-1', cannot be less than 0"
}
};
// Iterate over the scenarios.
PingCheckConfig default_config;
for (auto const& scenario : scenarios) {
stringstream oss;
oss << "scenario at line: " << scenario.line_;
SCOPED_TRACE(oss.str());
// Convert JSON text to a map of parameters.
ConstElementPtr json_elements;
ASSERT_NO_THROW_LOG(json_elements = Element::fromJSON(scenario.json_));
// Parsing parameters should throw.
PingCheckConfig config;
ASSERT_THROW_MSG(config.parse(json_elements), dhcp::DhcpConfigError,
scenario.exp_message_);
// Original values should be intact.
EXPECT_EQ(default_config.getEnablePingCheck(), config.getEnablePingCheck());
EXPECT_EQ(default_config.getMinPingRequests(), config.getMinPingRequests());
EXPECT_EQ(default_config.getReplyTimeout(), config.getReplyTimeout());
EXPECT_EQ(default_config.getPingClttSecs(), config.getPingClttSecs());
EXPECT_EQ(default_config.getPingChannelThreads(), config.getPingChannelThreads());
}
}
} // end of anonymous namespace
|