1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246 | // Copyright (C) 2012-2024 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
#include <config.h>
#include <util/unittests/wiredata.h>
#include <dns/exceptions.h>
#include <dns/rdata.h>
#include <dns/char_string.h>
#include <util/buffer.h>
#include <gtest/gtest.h><--- Include file: not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <string><--- Include file: not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <vector><--- Include file: not found. Please note: Cppcheck does not need standard library headers to get proper results.
using namespace isc::dns;
using namespace isc::dns::rdata;
using isc::dns::rdata::generic::detail::CharString;
using isc::dns::rdata::generic::detail::bufferToCharString;
using isc::dns::rdata::generic::detail::stringToCharString;
using isc::dns::rdata::generic::detail::charStringToString;
using isc::dns::rdata::generic::detail::compareCharStrings;
using isc::util::unittests::matchWireData;
namespace {
const uint8_t test_charstr[] = {
sizeof("Test String") - 1,
'T', 'e', 's', 't', ' ', 'S', 't', 'r', 'i', 'n', 'g'
};
class CharStringTest : public ::testing::Test {
protected:
CharStringTest() :
// char-string representation for test data using two types of escape
// ('r' = 114)
test_str("Test\\ St\\114ing")
{
str_region.beg = &test_str[0];
str_region.len = test_str.size();
}
CharString chstr; // place holder
const std::string test_str;
MasterToken::StringRegion str_region;
};
MasterToken::StringRegion
createStringRegion(const std::string& str) {
MasterToken::StringRegion region;
region.beg = &str[0]; // note std ensures this works even if str is empty
region.len = str.size();
return (region);
}
TEST_F(CharStringTest, normalConversion) {<--- syntax error
uint8_t tmp[3]; // placeholder for expected sequence
stringToCharString(str_region, chstr);
matchWireData(test_charstr, sizeof(test_charstr), &chstr[0], chstr.size());
// Empty string
chstr.clear();
stringToCharString(createStringRegion(""), chstr);
tmp[0] = 0;
matchWireData(tmp, 1, &chstr[0], chstr.size());
// Possible largest char string
chstr.clear();
std::string long_str(255, 'x');
stringToCharString(createStringRegion(long_str), chstr);
std::vector<uint8_t> expected;
expected.push_back(255); // len of char string
expected.insert(expected.end(), long_str.begin(), long_str.end());
matchWireData(&expected[0], expected.size(), &chstr[0], chstr.size());
// Same data as the previous case, but the original string is longer than
// the max; this shouldn't be rejected
chstr.clear();
long_str.at(254) = '\\'; // replace the last 'x' with '\'
long_str.append("120"); // 'x' = 120
stringToCharString(createStringRegion(long_str), chstr);
matchWireData(&expected[0], expected.size(), &chstr[0], chstr.size());
// Escaped '\'
chstr.clear();
tmp[0] = 1;
tmp[1] = '\\';
stringToCharString(createStringRegion("\\\\"), chstr);
matchWireData(tmp, 2, &chstr[0], chstr.size());
// Boundary values for \DDD
chstr.clear();
tmp[0] = 1;
tmp[1] = 0;
stringToCharString(createStringRegion("\\000"), chstr);
matchWireData(tmp, 2, &chstr[0], chstr.size());
chstr.clear();
stringToCharString(createStringRegion("\\255"), chstr);
tmp[0] = 1;
tmp[1] = 255;
matchWireData(tmp, 2, &chstr[0], chstr.size());
// Another digit follows DDD; it shouldn't cause confusion
chstr.clear();
stringToCharString(createStringRegion("\\2550"), chstr);
tmp[0] = 2; // string len is now 2
tmp[2] = '0';
matchWireData(tmp, 3, &chstr[0], chstr.size());
}
TEST_F(CharStringTest, badConversion) {
// string cannot exceed 255 bytes
EXPECT_THROW(stringToCharString(createStringRegion(std::string(256, 'a')),
chstr),
CharStringTooLong);
// input string ending with (non escaped) '\'
chstr.clear();
EXPECT_THROW(stringToCharString(createStringRegion("foo\\"), chstr),
InvalidRdataText);
}
TEST_F(CharStringTest, badDDD) {
// Check various type of bad form of \DDD
// Not a number
EXPECT_THROW(stringToCharString(createStringRegion("\\1a2"), chstr),
InvalidRdataText);
EXPECT_THROW(stringToCharString(createStringRegion("\\12a"), chstr),
InvalidRdataText);
// Not in the range of uint8_t
EXPECT_THROW(stringToCharString(createStringRegion("\\256"), chstr),
InvalidRdataText);
// Short buffer
EXPECT_THROW(stringToCharString(createStringRegion("\\42"), chstr),
InvalidRdataText);
}
const struct TestData {
const char *data;
const char *expected;
} conversion_data[] = {
{"Test\"Test", "Test\\\"Test"},
{"Test;Test", "Test\\;Test"},
{"Test\\Test", "Test\\\\Test"},
{"Test\x1fTest", "Test\\031Test"},
{"Test ~ Test", "Test ~ Test"},
{"Test\x7fTest", "Test\\127Test"},
{0, 0}
};
TEST_F(CharStringTest, charStringToString) {
for (const TestData* cur = conversion_data; cur->data; ++cur) {
uint8_t idata[32];
size_t length = std::strlen(cur->data);
// length (1 byte) + string (length bytes)
ASSERT_TRUE(sizeof(idata) > length);
idata[0] = static_cast<uint8_t>(length);
std::memcpy(idata + 1, cur->data, length);
const CharString test_data(idata, idata + length + 1);
EXPECT_EQ(cur->expected, charStringToString(test_data));
}
}
TEST_F(CharStringTest, bufferToCharString) {
const size_t chstr_size = sizeof(test_charstr);
isc::util::InputBuffer buf(test_charstr, chstr_size);
size_t read = bufferToCharString(buf, chstr_size, chstr);
EXPECT_EQ(chstr_size, read);
EXPECT_EQ("Test String", charStringToString(chstr));
}
TEST_F(CharStringTest, bufferToCharString_bad) {
const size_t chstr_size = sizeof(test_charstr);
isc::util::InputBuffer buf(test_charstr, chstr_size);
// Set valid data in both so we can make sure the charstr is not
// modified
bufferToCharString(buf, chstr_size, chstr);
ASSERT_EQ("Test String", charStringToString(chstr));
// Should be at end of buffer now, so it should fail
EXPECT_THROW(bufferToCharString(buf, chstr_size - 1, chstr),
DNSMessageFORMERR);
EXPECT_EQ("Test String", charStringToString(chstr));
// reset and try to read with too low rdata_len
buf.setPosition(0);
EXPECT_THROW(bufferToCharString(buf, chstr_size - 1, chstr),
DNSMessageFORMERR);
EXPECT_EQ("Test String", charStringToString(chstr));
// set internal charstring len too high
const uint8_t test_charstr_err[] = {
sizeof("Test String") + 1,
'T', 'e', 's', 't', ' ', 'S', 't', 'r', 'i', 'n', 'g'
};
buf = isc::util::InputBuffer(test_charstr_err, sizeof(test_charstr_err));
EXPECT_THROW(bufferToCharString(buf, chstr_size, chstr),
DNSMessageFORMERR);
EXPECT_EQ("Test String", charStringToString(chstr));
}
TEST_F(CharStringTest, compareCharString) {
CharString charstr;
CharString charstr2;
CharString charstr_small1;
CharString charstr_small2;
CharString charstr_large1;
CharString charstr_large2;
CharString charstr_empty;
stringToCharString(createStringRegion("test string"), charstr);
stringToCharString(createStringRegion("test string"), charstr2);
stringToCharString(createStringRegion("test strin"), charstr_small1);
stringToCharString(createStringRegion("test strina"), charstr_small2);
stringToCharString(createStringRegion("test stringa"), charstr_large1);
stringToCharString(createStringRegion("test strinz"), charstr_large2);
EXPECT_EQ(0, compareCharStrings(charstr, charstr2));
EXPECT_EQ(0, compareCharStrings(charstr2, charstr));
EXPECT_EQ(1, compareCharStrings(charstr, charstr_small1));
EXPECT_EQ(1, compareCharStrings(charstr, charstr_small2));
EXPECT_EQ(-1, compareCharStrings(charstr, charstr_large1));
EXPECT_EQ(-1, compareCharStrings(charstr, charstr_large2));
EXPECT_EQ(-1, compareCharStrings(charstr_small1, charstr));
EXPECT_EQ(-1, compareCharStrings(charstr_small2, charstr));
EXPECT_EQ(1, compareCharStrings(charstr_large1, charstr));
EXPECT_EQ(1, compareCharStrings(charstr_large2, charstr));
EXPECT_EQ(-1, compareCharStrings(charstr_empty, charstr));
EXPECT_EQ(1, compareCharStrings(charstr, charstr_empty));
EXPECT_EQ(0, compareCharStrings(charstr_empty, charstr_empty));
}
} // unnamed namespace
|