1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233 | // Copyright (C) 2011-2024 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
#ifndef TXT_LIKE_H
#define TXT_LIKE_H
#include <dns/master_lexer.h>
#include <dns/char_string.h>
#include <stdint.h><--- Include file: not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <algorithm><--- Include file: not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <string><--- Include file: not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <sstream><--- Include file: not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <vector><--- Include file: not found. Please note: Cppcheck does not need standard library headers to get proper results.
namespace isc {
namespace dns {
namespace rdata {
namespace generic {
namespace detail {
/// \brief \c rdata::TXTLikeImpl class represents the TXT-like RDATA for TXT
/// and SPF types.
///
/// This class implements the basic interfaces inherited by the TXT and SPF
/// classes from the abstract \c rdata::Rdata class, and provides trivial
/// accessors to TXT-like RDATA.
template<class Type, uint16_t typeCode>class TXTLikeImpl {
public:
/// \brief Constructor from wire-format data.
///
/// \param buffer A buffer storing the wire format data.
/// \param rdata_len The length of the RDATA in bytes, normally expected
/// to be the value of the RDLENGTH field of the corresponding RR.
///
/// <b>Exceptions</b>
///
/// \c InvalidRdataLength is thrown if rdata_len exceeds the maximum.
/// \c DNSMessageFORMERR is thrown if the RR is malformed.
TXTLikeImpl(util::InputBuffer& buffer, size_t rdata_len) {
if (rdata_len > MAX_RDLENGTH) {
isc_throw(InvalidRdataLength, "RDLENGTH too large: " << rdata_len);
}
if (rdata_len == 0) { // note that this couldn't happen in the loop.
isc_throw(DNSMessageFORMERR, "Error in parsing " <<
RRType(typeCode) << " RDATA: 0-length character string");
}
do {
const uint8_t len = buffer.readUint8();
if (rdata_len < len + 1) {
isc_throw(DNSMessageFORMERR, "Error in parsing " <<
RRType(typeCode) <<
" RDATA: character string length is too large: " <<
static_cast<int>(len));
}
std::vector<uint8_t> data(len + 1);
data[0] = len;
buffer.readData(&data[0] + 1, len);
string_list_.push_back(data);
rdata_len -= (len + 1);
} while (rdata_len > 0);
}
/// \brief Constructor from string.
///
/// \throw CharStringTooLong the parameter string length exceeds maximum.
/// \throw InvalidRdataText the method cannot process the parameter data
explicit TXTLikeImpl(const std::string& txtstr) {
std::istringstream ss(txtstr);
MasterLexer lexer;
lexer.pushSource(ss);
try {
buildFromTextHelper(lexer);
if (lexer.getNextToken().getType() != MasterToken::END_OF_FILE) {
isc_throw(InvalidRdataText, "Failed to construct " <<
RRType(typeCode) << " RDATA from '" << txtstr <<
"': extra new line");
}
} catch (const MasterLexer::LexerError& ex) {
isc_throw(InvalidRdataText, "Failed to construct " <<
RRType(typeCode) << " RDATA from '" << txtstr << "': "
<< ex.what());
}
}
/// \brief Constructor using the master lexer.
///
/// \throw CharStringTooLong the parameter string length exceeds maximum.
/// \throw InvalidRdataText the method cannot process the parameter data
///
/// \param lexer A \c MasterLexer object parsing a master file for this
/// RDATA.
TXTLikeImpl(MasterLexer& lexer) {<--- Class 'TXTLikeImpl < TXT , 16 >' has a constructor with 1 argument that is not explicit. [+]Class 'TXTLikeImpl < TXT , 16 >' has a constructor with 1 argument that is not explicit. Such, so called "Converting constructors", should in general be explicit for type safety reasons as that prevents unintended implicit conversions.
buildFromTextHelper(lexer);
}
private:
void buildFromTextHelper(MasterLexer& lexer) {
while (true) {
const MasterToken& token = lexer.getNextToken(
MasterToken::QSTRING, true);
if (token.getType() != MasterToken::STRING &&
token.getType() != MasterToken::QSTRING) {
break;
}
string_list_.push_back(std::vector<uint8_t>());
stringToCharString(token.getStringRegion(), string_list_.back());
}
// Let upper layer handle eol/eof.
lexer.ungetToken();
if (string_list_.empty()) {
isc_throw(InvalidRdataText, "Failed to construct " <<
RRType(typeCode) << " RDATA: empty input");
}
}
public:
/// \brief The copy constructor.
///
/// Trivial for now, we could've used the default one.
TXTLikeImpl(const TXTLikeImpl& other) :
string_list_(other.string_list_)
{}
/// \brief Render the TXT-like data in the wire format to an OutputBuffer
/// object.
///
/// \param buffer An output buffer to store the wire data.
void
toWire(util::OutputBuffer& buffer) const {
for (std::vector<std::vector<uint8_t> >::const_iterator it =
string_list_.begin();
it != string_list_.end();
++it)
{
buffer.writeData(&(*it)[0], (*it).size());
}
}
/// \brief Render the TXT-like data in the wire format to an
/// AbstractMessageRenderer object.
///
/// \param renderer An output AbstractMessageRenderer to send the wire data
/// to.
void
toWire(AbstractMessageRenderer& renderer) const {
for (std::vector<std::vector<uint8_t> >::const_iterator it =
string_list_.begin();
it != string_list_.end();
++it)
{
renderer.writeData(&(*it)[0], (*it).size());
}
}
/// \brief Convert the TXT-like data to a string.
///
/// \return A \c string object that represents the TXT-like data.
std::string
toText() const {
std::string s;
for (std::vector<std::vector<uint8_t> >::const_iterator it =
string_list_.begin(); it != string_list_.end(); ++it)
{
if (!s.empty()) {
s.push_back(' ');
}
s.push_back('"');
s.append(charStringToString(*it));
s.push_back('"');
}
return (s);
}
/// \brief Compare two instances of TXT-like RDATA.
///
/// It is up to the caller to make sure that \c other is an object of the
/// same \c TXTLikeImpl class.
///
/// \param other the right-hand operand to compare against.
/// \return < 0 if \c this would be sorted before \c other.
/// \return 0 if \c this is identical to \c other in terms of sorting
/// order.
/// \return > 0 if \c this would be sorted after \c other.
int
compare(const TXTLikeImpl& other) const {
// This implementation is not efficient. Revisit this (TBD).
util::OutputBuffer this_buffer(0);
toWire(this_buffer);
uint8_t const* const this_data = (uint8_t const*)this_buffer.getData();<--- C-style pointer casting [+]C-style pointer casting detected. C++ offers four different kinds of casts as replacements: static_cast, const_cast, dynamic_cast and reinterpret_cast. A C-style cast could evaluate to any of those automatically, thus it is considered safer if the programmer explicitly states which kind of cast is expected.
const size_t this_len = this_buffer.getLength();
util::OutputBuffer other_buffer(0);
other.toWire(other_buffer);
uint8_t const* const other_data
= (uint8_t const*)other_buffer.getData();<--- C-style pointer casting [+]C-style pointer casting detected. C++ offers four different kinds of casts as replacements: static_cast, const_cast, dynamic_cast and reinterpret_cast. A C-style cast could evaluate to any of those automatically, thus it is considered safer if the programmer explicitly states which kind of cast is expected.
const size_t other_len = other_buffer.getLength();
const size_t cmplen = std::min(this_len, other_len);
const int cmp = memcmp(this_data, other_data, cmplen);
if (cmp != 0) {
return (cmp);
} else {
return ((this_len == other_len) ? 0 :
(this_len < other_len) ? -1 : 1);
}
}
private:
/// Note: this is a prototype version; we may reconsider
/// this representation later.
std::vector<std::vector<uint8_t> > string_list_;
};
} // namespace detail
} // namespace generic
} // namespace rdata
} // namespace dns
} // namespace isc
#endif // TXT_LIKE_H
|