// Copyright (C) 2010-2024 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
#include <config.h>
#include <dns/messagerenderer.h>
#include <dns/name.h>
#include <dns/question.h>
#include <dns/rrclass.h>
#include <dns/rrtype.h>
#include <util/buffer.h>
#include <iostream><--- Include file: not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <string><--- Include file: not found. Please note: Cppcheck does not need standard library headers to get proper results.
using namespace isc::util;
using namespace std;
namespace isc {
namespace dns {
Question::Question(InputBuffer& buffer) :
name_(buffer), rrtype_(0), rrclass_(0) {
// In theory, we could perform this in the member initialization list,
// and it would be a little bit more efficient. We don't do this, however,
// because the initialization ordering is crucial (type must be first)
// and the ordering in the initialization list depends on the appearance
// order of member variables. It's fragile to rely on such an implicit
// dependency, so we make the initialization order explicit.
rrtype_ = RRType(buffer);<--- Variable 'rrtype_' is assigned in constructor body. Consider performing initialization in initialization list. [+]When an object of a class is created, the constructors of all member variables are called consecutively in the order the variables are declared, even if you don't explicitly write them to the initialization list. You could avoid assigning 'rrtype_' a value by passing the value to the constructor in the initialization list.
rrclass_ = RRClass(buffer);
}
std::string
Question::toText(bool newline) const {
std::string r(name_.toText() + " " + rrclass_.toText() + " " +
rrtype_.toText());
if (newline) {
r.append("\n");
}
return (r);
}
uint32_t
Question::toWire(OutputBuffer& buffer) const {
name_.toWire(buffer);
rrtype_.toWire(buffer);
rrclass_.toWire(buffer); // number of "entries", which is always 1
return (1);
}
uint32_t
Question::toWire(AbstractMessageRenderer& renderer) const {
const size_t pos0 = renderer.getLength();
renderer.writeName(name_);
rrtype_.toWire(renderer);
rrclass_.toWire(renderer);
// Make sure the renderer has a room for the question
if (renderer.getLength() > renderer.getLengthLimit()) {
renderer.trim(renderer.getLength() - pos0);
renderer.setTruncated();
return (0);
}
return (1); // number of "entries"
}
ostream&
operator<<(std::ostream& os, const Question& question) {
os << question.toText();
return (os);
}
}
}