1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293 | // Copyright (C) 2011-2024 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
#include <config.h>
#include <dhcp/classify.h>
#include <exceptions/exceptions.h>
#include <cc/data.h>
#include <testutils/gtest_utils.h>
#include <gtest/gtest.h><--- Include file: not found. Please note: Cppcheck does not need standard library headers to get proper results.
using namespace isc;
using namespace isc::dhcp;
using namespace isc::data;
// Trivial test for now as ClientClass is a std::string.
TEST(ClassifyTest, ClientClass) {
ClientClass x("foo");
EXPECT_EQ("foo", x);
x = "baz";
EXPECT_EQ("baz", x);
}
// Checks if ClientClasses object is able to store classes' names and then
// properly return values of contains() method.
TEST(ClassifyTest, ClientClasses) {
ClientClasses classes;
EXPECT_FALSE(classes.contains(""));
EXPECT_FALSE(classes.contains("alpha"));
EXPECT_FALSE(classes.contains("beta"));
EXPECT_FALSE(classes.contains("gamma"));
classes.insert("beta");
EXPECT_FALSE(classes.contains(""));
EXPECT_FALSE(classes.contains("alpha"));
EXPECT_TRUE (classes.contains("beta"));
EXPECT_FALSE(classes.contains("gamma"));
classes.insert("alpha");
classes.insert("gamma");
EXPECT_TRUE (classes.contains("alpha"));
EXPECT_TRUE (classes.contains("beta"));
EXPECT_TRUE (classes.contains("gamma"));
// Copy Constructor and equality operators.
ClientClasses classes2(classes);
EXPECT_EQ(classes, classes2);
// A bigger than B
classes.insert("zeta");
EXPECT_NE(classes, classes2);
// A and B equal again.
classes2.insert("zeta");
EXPECT_EQ(classes, classes2);
// B bigger than A.
classes2.insert("chi");
EXPECT_NE(classes, classes2);
// Order matters.
ClientClasses classes3;
classes3.insert("alpha");
classes3.insert("gamma");
classes3.insert("beta");
classes3.insert("zeta");
EXPECT_EQ(classes3.size(), classes.size());
EXPECT_NE(classes3, classes);
}
// Check if ClientClasses object can be created from the string of comma
// separated values.
TEST(ClassifyTest, ClientClassesFromString) {
{
ClientClasses classes("alpha, beta, gamma");
EXPECT_EQ(3, classes.size());
EXPECT_FALSE(classes.contains(""));
EXPECT_TRUE(classes.contains("alpha"));
EXPECT_TRUE(classes.contains("beta"));
EXPECT_TRUE(classes.contains("gamma"));
}
{
ClientClasses classes("alpha, , beta ,");
EXPECT_EQ(2, classes.size());
EXPECT_TRUE(classes.contains("alpha"));
EXPECT_FALSE(classes.contains(""));
EXPECT_TRUE(classes.contains("beta"));
}
{
ClientClasses classes("");
EXPECT_TRUE(classes.empty());
}
{
ClientClasses classes(" ");
EXPECT_TRUE(classes.empty());
}
{
ClientClasses classes(", ,, ,");
EXPECT_TRUE(classes.empty());
}
}
// Check if one can iterate over a ClientClasses object
TEST(ClassifyTest, ClientClassesIterator) {
ClientClasses classes("alpha, beta, gamma");
size_t count = 0;
bool seenalpha = false;
bool seenbeta = false;
bool seengamma = false;
bool seendelta = false;
for (auto const& it : classes) {
++count;
if (it == "alpha") {
seenalpha = true;
} else if (it == "beta") {
seenbeta = true;
} else if (it == "gamma") {
seengamma = true;
} else if (it == "delta") {
seendelta = true;
} else {
ADD_FAILURE() << "Got unexpected " << it;
}
}
EXPECT_EQ(count, classes.size());
EXPECT_TRUE(seenalpha);
EXPECT_TRUE(seenbeta);
EXPECT_TRUE(seengamma);
EXPECT_FALSE(seendelta);
}
// Check that the ClientClasses::toText function returns
// correct values.
TEST(ClassifyTest, ClientClassesToText) {
// No classes.
ClientClasses classes;
EXPECT_TRUE(classes.toText().empty());
// Insert single class name and see if it doesn't include spurious
// comma after it.
classes.insert("alpha");
EXPECT_EQ("alpha", classes.toText());
// Insert next class name and see that both classes are present.
classes.insert("gamma");
EXPECT_EQ("alpha, gamma", classes.toText());
// Insert third class and make sure they get ordered in insert order.
classes.insert("beta");
EXPECT_EQ("alpha, gamma, beta", classes.toText());
// Check non-standard separator.
EXPECT_EQ("alpha.gamma.beta", classes.toText("."));
}
// Check that the ClientClasses::toElement function returns
// correct values.
TEST(ClassifyTest, ClientClassesToElement) {
// No classes.
ClientClasses classes;
EXPECT_TRUE(classes.toElement()->empty());
// Insert single class name and see that it's there.
classes.insert("alpha");
EXPECT_EQ("[ \"alpha\" ]", classes.toElement()->str());
// Insert next class name and see that both classes are present.
classes.insert("gamma");
EXPECT_EQ("[ \"alpha\", \"gamma\" ]", classes.toElement()->str());
// Insert third class and make sure they get ordered in insert order.
classes.insert("beta");
EXPECT_EQ("[ \"alpha\", \"gamma\", \"beta\" ]", classes.toElement()->str());
}
// Check that selected class can be erased.
TEST(ClassifyTest, Erase) {
ClientClasses classes;
classes.insert("alpha");
classes.insert("beta");
EXPECT_TRUE(classes.contains("alpha"));
EXPECT_TRUE(classes.contains("beta"));
classes.erase("beta");
EXPECT_TRUE(classes.contains("alpha"));
EXPECT_FALSE(classes.contains("beta"));
classes.erase("alpha");
EXPECT_FALSE(classes.contains("alpha"));
EXPECT_FALSE(classes.contains("beta"));
}
// Check that the ClientClasses::fromElement function.
TEST(ClassifyTest, ClientClassesFromElement) {
// No classes.
ClientClasses classes;
EXPECT_TRUE(classes.toElement()->empty());
ElementPtr cclasses_element;
// Verify a empty element pointer is harmless.
ASSERT_NO_THROW(classes.fromElement(cclasses_element));
// Verify A non-list element is caught.
cclasses_element = Element::create("bogus");
ASSERT_THROW_MSG(classes.fromElement(cclasses_element), BadValue,
"not a List element");
// Verify an empty list is harmless.
cclasses_element = Element::createList();
// Verify a empty element pointer is harmless.
ASSERT_NO_THROW(classes.fromElement(cclasses_element));
// Verify an invalid list is caught.
cclasses_element->add(Element::create(123));
ASSERT_THROW_MSG(classes.fromElement(cclasses_element), BadValue,
"elements of list must be valid strings");
cclasses_element = Element::createList();
cclasses_element->add(Element::create("one"));
cclasses_element->add(Element::create("two"));
// Verify a valid list works.
ASSERT_NO_THROW(classes.fromElement(cclasses_element));
EXPECT_TRUE(classes.contains("one"));
EXPECT_TRUE(classes.contains("two"));
// Verify a second invocation replaces the contents.
cclasses_element = Element::createList();
cclasses_element->add(Element::create("three"));
ASSERT_NO_THROW(classes.fromElement(cclasses_element));
EXPECT_FALSE(classes.contains("one"));
EXPECT_FALSE(classes.contains("two"));
EXPECT_TRUE(classes.contains("three"));
// Verify another invocation with an empty pointer is harmless.
cclasses_element.reset();
ASSERT_NO_THROW(classes.fromElement(cclasses_element));
EXPECT_TRUE(classes.contains("three"));
// Verify another third invocation with an empty list
// clears the contents.
cclasses_element = Element::createList();
ASSERT_NO_THROW(classes.fromElement(cclasses_element));
EXPECT_TRUE(classes.empty());
cclasses_element->add(Element::create("foo"));
cclasses_element->add(Element::create("bar"));
cclasses_element->add(Element::create("foo"));
cclasses_element->add(Element::create("bar"));
ASSERT_NO_THROW(classes.fromElement(cclasses_element));
ASSERT_EQ(classes.size(), 2);
auto cclass = classes.begin();
EXPECT_EQ(*cclass, "foo");
++cclass;
EXPECT_EQ(*cclass, "bar");
}
// Check that the ClientClasses::intersects function works.
TEST(ClassifyTest, ClientClassesIntersects) {
ClientClasses classes1;
ClientClasses classes2;
EXPECT_FALSE(classes1.intersects(classes2));
EXPECT_FALSE(classes2.intersects(classes1));
classes1.insert("one");
EXPECT_FALSE(classes1.intersects(classes2));
EXPECT_FALSE(classes2.intersects(classes1));
classes2.insert("two");
classes2.insert("three");
EXPECT_FALSE(classes1.intersects(classes2));
EXPECT_FALSE(classes2.intersects(classes1));
classes2.insert("one");
EXPECT_TRUE(classes1.intersects(classes2));
EXPECT_TRUE(classes2.intersects(classes1));
}
|