// Copyright (C) 2022-2023 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
#include <config.h>
#include <dhcpsrv/allocation_state.h>
#include <util/multi_threading_mgr.h>
#include <boost/date_time/posix_time/posix_time.hpp><--- Include file: not found. Please note: Cppcheck does not need standard library headers to get proper results.
using namespace isc::util;
namespace isc {
namespace dhcp {
SubnetAllocationState::SubnetAllocationState()
: AllocationState(), mutex_(new std::mutex) {
last_allocated_time_ = boost::posix_time::neg_infin;<--- Variable 'last_allocated_time_' is assigned in constructor body. Consider performing initialization in initialization list. [+]When an object of a class is created, the constructors of all member variables are called consecutively in the order the variables are declared, even if you don't explicitly write them to the initialization list. You could avoid assigning 'last_allocated_time_' a value by passing the value to the constructor in the initialization list.
}
boost::posix_time::ptime
SubnetAllocationState::getLastAllocatedTime() const {
MultiThreadingLock lock(*mutex_);<--- Variable 'lock' is assigned a value that is never used.
return (last_allocated_time_);
}
void
SubnetAllocationState::setCurrentAllocatedTimeInternal() {
last_allocated_time_ = boost::posix_time::microsec_clock::universal_time();
}
}
}